[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

[David Spickett via lldb-commits]

================
@@ -1465,6 +1465,20 @@ class Process : public std::enable_shared_from_this<Process>,
   /// platforms where there is a difference (only Arm Thumb at this time).
   lldb::addr_t FixAnyAddress(lldb::addr_t pc);
 
+  /// Retrieve the actual address masks for high memory code/data,
+  /// without the normal fallbacks of returning the low-memory masks
+  /// or the user settings.  Needed by SBProcess to determine if
+  /// the high address masks have actually been set, and should
+  /// be updated when "set all masks" is requested.  In most cases,
+  /// the highmem masks should be left to have LLDB_INVALID_ADDRESS_MASK,
+  /// unset.
+  lldb::addr_t GetConcreteHighmemCodeAddressMask() {
----------------
DavidSpickett wrote:

All this makes me wonder if this can be `optional<lldb:addr_t>` but we're already knee deep in the `INVALID_` style and it would only obscure the intent of this patch.

https://github.com/llvm/llvm-project/pull/90533