[Lldb-commits] [lldb] Fix lock guads in PipePosix.cpp (PR #90572)
via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 30 01:06:09 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Danial Klimkin (dklimkin)
<details>
<summary>Changes</summary>
Guard object destroyed immediately after creation without naming.
---
Full diff: https://github.com/llvm/llvm-project/pull/90572.diff
1 Files Affected:
- (modified) lldb/source/Host/posix/PipePosix.cpp (+2-2)
``````````diff
diff --git a/lldb/source/Host/posix/PipePosix.cpp b/lldb/source/Host/posix/PipePosix.cpp
index afd3fe39059ac1..f35c348990df62 100644
--- a/lldb/source/Host/posix/PipePosix.cpp
+++ b/lldb/source/Host/posix/PipePosix.cpp
@@ -108,7 +108,7 @@ Status PipePosix::CreateNew(bool child_processes_inherit) {
}
Status PipePosix::CreateNew(llvm::StringRef name, bool child_process_inherit) {
- std::scoped_lock<std::mutex, std::mutex> (m_read_mutex, m_write_mutex);
+ std::scoped_lock<std::mutex, std::mutex> guard(m_read_mutex, m_write_mutex);
if (CanReadUnlocked() || CanWriteUnlocked())
return Status("Pipe is already opened");
@@ -146,7 +146,7 @@ Status PipePosix::CreateWithUniqueName(llvm::StringRef prefix,
Status PipePosix::OpenAsReader(llvm::StringRef name,
bool child_process_inherit) {
- std::scoped_lock<std::mutex, std::mutex> (m_read_mutex, m_write_mutex);
+ std::scoped_lock<std::mutex, std::mutex> guard(m_read_mutex, m_write_mutex);
if (CanReadUnlocked() || CanWriteUnlocked())
return Status("Pipe is already opened");
``````````
</details>
https://github.com/llvm/llvm-project/pull/90572
More information about the lldb-commits
mailing list