[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

[Alex Langford via lldb-commits]

================
@@ -321,13 +321,22 @@ class LLDB_API SBDebugger {
 
   void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
 
+  /// DEPRECATED: We used to only support one Destroy callback. Now that we
+  /// support Add and Remove, you should only remove Destroy callbacks that
+  /// you Add-ed. Use Add and Remove instead.
+  ///
+  /// Clear all previously added callbacks and only add the given one.
   void SetDestroyCallback(lldb::SBDebuggerDestroyCallback destroy_callback,
----------------
bulbazord wrote:

There are some macros you can use in addition to the documentation: `LLDB_DEPRECATED_FIXME`. This will give compiler warnings to anyone using `SetDestroyCallback` so they can update their code.

https://github.com/llvm/llvm-project/pull/89868