[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 26 11:41:54 PDT 2024


labath wrote:

> > [this](https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml) test seems to indicate that's possible (the trick appears to me in `(n)` name tag suffixes). Can you give that a shot?
> 
> I've actually just included a binary file that exhibits the problem.

I saw that, but a textual test is definitely preferable, particularly after the linux xz fiasco. This wouldn't be the first test binary in our repo, but in this case, I think it actually adds a lot of value, since yaml2obj operates on the same level as what you are testing (so you can see the input of the test eyeball-verify that the expected output makes sense).

https://github.com/llvm/llvm-project/pull/90099


More information about the lldb-commits mailing list