[Lldb-commits] [lldb] c8627e4 - Revert "[lldb] Provide a better error message for missing symbols (#89433)"

[Adrian Prantl via lldb-commits]

Author: Adrian Prantl
Date: 2024-04-19T16:37:09-07:00
New Revision: c8627e4e0c8ac453844638522b887ac7b7687672

URL: https://github.com/llvm/llvm-project/commit/c8627e4e0c8ac453844638522b887ac7b7687672
DIFF: https://github.com/llvm/llvm-project/commit/c8627e4e0c8ac453844638522b887ac7b7687672.diff

LOG: Revert "[lldb] Provide a better error message for missing symbols (#89433)"

This reverts commit 08163cd9d82690e808c28515523b5fd0923d7b38.

I accidentally broke the test while addressing review feedback.

Added: 
    

Modified: 
    lldb/source/Expression/IRExecutionUnit.cpp
    lldb/test/API/lang/cpp/constructors/TestCppConstructors.py

Removed: 
    


################################################################################
diff  --git a/lldb/source/Expression/IRExecutionUnit.cpp b/lldb/source/Expression/IRExecutionUnit.cpp
index 07df8c52a2a4f0..cb9bee8733e15d 100644
--- a/lldb/source/Expression/IRExecutionUnit.cpp
+++ b/lldb/source/Expression/IRExecutionUnit.cpp
@@ -431,9 +431,7 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr,
     }
 
     m_failed_lookups.clear();
-    ss.PutCString(
-        "\nHint: The expression tried to call a function that is not present "
-        "in the target, perhaps because it was optimized out by the compiler.");
+
     error.SetErrorString(ss.GetString());
 
     return;

diff  --git a/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py b/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py
index 140877adba735a..6724bfc8ed78e0 100644
--- a/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py
+++ b/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py
@@ -47,7 +47,7 @@ def test_constructors(self):
         self.expect(
             "expr ClassWithDeletedDefaultCtor().value",
             error=True,
-            substrs=["Couldn't look up symbols:", "function missing"],
+            substrs=["Couldn't look up symbols:"],
         )
 
     @skipIfWindows  # Can't find operator new.