[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

[Jonas Devlieghere via lldb-commits]

================
@@ -3419,7 +3419,7 @@ bool GDBRemoteCommunicationClient::GetFileExists(
 }
 
 bool GDBRemoteCommunicationClient::CalculateMD5(
-    const lldb_private::FileSpec &file_spec, uint64_t &high, uint64_t &low) {
+    const lldb_private::FileSpec &file_spec, uint64_t &low, uint64_t &high) {
----------------
JDevlieghere wrote:

If we're changing the interface anyway, could we have this return an `std::optional<llvm::MD5::MD5Result>` to match what `md5_contents` returns? 

https://github.com/llvm/llvm-project/pull/88812