[Lldb-commits] [lldb] adds additional information to the ProcessInfo object for elf processes (PR #88995)

[via lldb-commits]

jimingham wrote:

Yes, you'd have to put this test into a host test for a system that doesn't support this, like use the Posix one or make one for the Windows or Darwin Hosts.

Jim


> On Apr 17, 2024, at 10:43 AM, Fred Grim ***@***.***> wrote:
> 
> 
> That test looks good. It seems unlikely that you would buggily always produce monotonically increasing times...
> 
> Not to be a pest, but since this info is only provided on Linux, we should maybe add a test to make sure that asking for this information on systems that don't provide it fails gracefully?
> 
> Actually looking at lldb/unittest/Host/CMakeLists.txt I see:
> 
> if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android")
>     list(APPEND FILES
>       linux/HostTest.cpp
>       linux/SupportTest.cpp
>  )
> endif()
> which should ensure the test is never built nor executed outside of linux
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/88995#issuecomment-2061865055>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW7HRQWYIILTSSGNIUDY52YF5AVCNFSM6AAAAABGKEUICSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHA3DKMBVGU>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/88995