[Lldb-commits] [lldb] a16bb07 - [lldb][test] Improve invalid compiler error message

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 17 02:19:43 PDT 2024


Author: David Spickett
Date: 2024-04-17T09:19:26Z
New Revision: a16bb0701409376dee3a587ae351a6019d6de4e0

URL: https://github.com/llvm/llvm-project/commit/a16bb0701409376dee3a587ae351a6019d6de4e0
DIFF: https://github.com/llvm/llvm-project/commit/a16bb0701409376dee3a587ae351a6019d6de4e0.diff

LOG: [lldb][test] Improve invalid compiler error message

I was debugging space separation issues when passing user arguments
and noticed this error is really hard to read in that scenario.

Put "" around the invalid compiler name so you can tell whether
you have spaces around it that's causing the problem.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/dotest.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index 8c29145ecc5272..2ec4a840b91675 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -248,7 +248,7 @@ def parseOptionsAndInitTestdirs():
             configuration.compiler = which(args.compiler)
         if not is_exe(configuration.compiler):
             logging.error(
-                "%s is not a valid compiler executable; aborting...", args.compiler
+                '"%s" is not a valid compiler executable; aborting...', args.compiler
             )
             sys.exit(-1)
     else:


        


More information about the lldb-commits mailing list