[Lldb-commits] [lldb] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam (PR #88564)

[via lldb-commits]

jeffreytan81 wrote:

Thanks for fixing this. 

There are several related issues in the failing tests:
1. At least some of the memory regions ReadMemory() failures are caused by we incorrectly try to read from non-readable regions. We should explicitly check we have at least read permission. 
2. The current ObjectFile plugin model swallow any error from the corresponding object file plugin and report a generic "Failed to save core file for process: no ObjectFile plugins were able to save a core for this process". We should distinguish the error reporting from "I do not support" from "I tried but got an error" and let users know. 
3. As a stretch goal, we should implement "MemoryInfoList" stream type in minidump, then users can know what memory regions are available in original memory process space, but when he failed to read memory from that memory region/address during post-mortem debugging, it would be hint that that region exists but we just failed to save it. 



https://github.com/llvm/llvm-project/pull/88564