[Lldb-commits] [lldb] Reapply "Fix error in unrecognized register name handling for "SBFram…e.register"" (#88468)" (PR #88535)

[Alex Langford via lldb-commits]

================
@@ -91,7 +93,17 @@ def test_get_arg_vals_for_call_stack(self):
                     frame.GetSP(),
                     "SP gotten as a value should equal frame's GetSP",
                 )
-
+                # Test that the "register" property's flat list matches the list from
+                # the "registers" property that returns register sets:
+                register_regs = set()
+                flattened_regs = set()
+                for reg_set in frame.registers:
+                    for reg in reg_set:
+                        flattened_regs.add(reg.name)
+                for reg in frame.register:
+                    register_regs.add(reg.name)
----------------
bulbazord wrote:

Oh, I see now. I definitely did not notice the difference between `frame.register` and `frame.registers`... I wish we could change that. Maybe we could make `frame.register_sets` an alias for `frame.registers` and switch to using that?

https://github.com/llvm/llvm-project/pull/88535