[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 5 14:24:17 PDT 2024


================
@@ -21,9 +21,11 @@ class SymbolFileDWARFDwo;
 class ManualDWARFIndex : public DWARFIndex {
 public:
   ManualDWARFIndex(Module &module, SymbolFileDWARF &dwarf,
-                   llvm::DenseSet<dw_offset_t> units_to_avoid = {})
+                   llvm::DenseSet<dw_offset_t> units_to_avoid = {},
+                   llvm::DenseSet<uint64_t> type_sigs_to_avoid = {})
       : DWARFIndex(module), m_dwarf(&dwarf),
-        m_units_to_avoid(std::move(units_to_avoid)) {}
+        m_units_to_avoid(std::move(units_to_avoid)),
+        m_type_sigs_to_avoid(type_sigs_to_avoid) {}
----------------
bulbazord wrote:

nit: If we are going to std::move `units_to_avoid`, we should do the same for `m_type_sigs_to_avoid`. It's the same situation.

https://github.com/llvm/llvm-project/pull/87740


More information about the lldb-commits mailing list