[Lldb-commits] [lldb] [lldb][ClangUserExpression][NFCI] Pass the most specific ExecutionContextScope possible into ClangExpressionParser (PR #87657)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 5 09:10:40 PDT 2024
================
@@ -669,15 +670,8 @@ bool ClangUserExpression::Parse(DiagnosticManager &diagnostic_manager,
// Parse the expression
//
- Process *process = exe_ctx.GetProcessPtr();
- ExecutionContextScope *exe_scope = process;
-
- if (!exe_scope)
- exe_scope = exe_ctx.GetTargetPtr();
-
- bool parse_success = TryParse(diagnostic_manager, exe_scope, exe_ctx,
- execution_policy, keep_result_in_memory,
- generate_debug_info);
+ bool parse_success = TryParse(diagnostic_manager, exe_ctx, execution_policy,
+ keep_result_in_memory, generate_debug_info);
----------------
jimingham wrote:
At some point we should go through and rationalize the use of ExecutionContext vrs. ExecutionContextScope, but this patch doesn't seem the place to do that. Instead, going with whatever is locally most convenient seems the right choice here.
https://github.com/llvm/llvm-project/pull/87657
More information about the lldb-commits
mailing list