[Lldb-commits] [lldb] [lldb][ClangUserExpression][NFCI] Pass the most specific ExecutionContextScope possible into ClangExpressionParser (PR #87657)

[via lldb-commits]

================
@@ -553,9 +553,9 @@ bool ClangUserExpression::PrepareForParsing(
 }
 
 bool ClangUserExpression::TryParse(
-    DiagnosticManager &diagnostic_manager, ExecutionContextScope *exe_scope,
-    ExecutionContext &exe_ctx, lldb_private::ExecutionPolicy execution_policy,
-    bool keep_result_in_memory, bool generate_debug_info) {
+    DiagnosticManager &diagnostic_manager, ExecutionContext &exe_ctx,
+    lldb_private::ExecutionPolicy execution_policy, bool keep_result_in_memory,
+    bool generate_debug_info) {
----------------
jimingham wrote:

I was also mostly moved by the fact that there were two things specifying what should be one thing.  I was hoping that this was just redundant, not someone being overly clever, and Michael showed that it wasn't a used distinction, which is good.  As far as which type to use, that's really more convenience, right?  If the methods you want to call immediately from TryParse take ExecutionContextScopes, use that, if ExecutionContext's, use that.  I don't think it makes any other difference.

https://github.com/llvm/llvm-project/pull/87657