[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 2 08:10:35 PDT 2024


================
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry {
 
   lldb::SBAddress GetEndAddress() const;
 
+  lldb::SBAddress
+  GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const;
+
----------------
jeffreytan81 wrote:

I take a second look at `GetSameLineContiguousAddressRangeEnd` implementation, it seems to take care of compiler generate code and inline functions which I find it is tedious to duplicate the implementation in lldb-dap: 
https://github.com/llvm/llvm-project/blob/a6d932bca8875198fbf34564cda8a8d1640cdcbc/lldb/source/Symbol/LineEntry.cpp#L202-L233

So I think it makes more sense to reuse it. Please take a further review. Thanks.

https://github.com/llvm/llvm-project/pull/86623


More information about the lldb-commits mailing list