[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 27 14:34:59 PDT 2024


================
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry {
 
   lldb::SBAddress GetEndAddress() const;
 
+  lldb::SBAddress
+  GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const;
+
----------------
jeffreytan81 wrote:

@clayborg, right, I know I can do that but I did not use it for two reasons:
1. That seems to be what `GetSameLineContiguousAddressRangeEnd` API is doing internally so I prefer to reuse the API than implement myself.
2. This seems to depend on the dwarf line table encoding which may not work for other platforms like PDB? Hiding behind `GetSameLineContiguousAddressRangeEnd` makes the code more resilient? 

Anyway, if you still prefer us calling "GetLineEntryAtIndex" repeat, I will change it.

https://github.com/llvm/llvm-project/pull/86623


More information about the lldb-commits mailing list