[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

[Greg Clayton via lldb-commits]

================
@@ -811,23 +811,34 @@ def request_next(self, threadId):
         command_dict = {"command": "next", "type": "request", "arguments": args_dict}
         return self.send_recv(command_dict)
 
-    def request_stepIn(self, threadId):
+    def request_stepInTargets(self, frameId):
         if self.exit_status is not None:
-            raise ValueError("request_continue called after process exited")
-        args_dict = {"threadId": threadId}
+            raise ValueError("request_stepInTargets called after process exited")
+        args_dict = {"frameId": frameId}
+        command_dict = {
+            "command": "stepInTargets",
+            "type": "request",
+            "arguments": args_dict,
+        }
+        return self.send_recv(command_dict)
----------------
clayborg wrote:

Can you move `request_stepInTargets` after the `request_stepIn(self, threadID):` So the diff doesn't get muddled up? Right now it thinks you rewrite `request_stepIn`, but if you add `request_stepInTargets` after this function the diff will be easier to read.

https://github.com/llvm/llvm-project/pull/86623