[Lldb-commits] [lldb] [lldb][Dwarf] Fix dwarf parse time for line table and .debug_abbrev. (PR #86568)

Zequan Wu via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 25 13:19:31 PDT 2024


================
@@ -1228,10 +1231,9 @@ bool SymbolFileDWARF::ParseLineTable(CompileUnit &comp_unit) {
   if (offset == DW_INVALID_OFFSET)
     return false;
 
-  ElapsedTime elapsed(m_parse_time);
----------------
ZequanWu wrote:

My understanding is m_parse_time is the time spent only on parsing the raw data and not about constructing the data structures which will be used by lldb. In https://github.com/llvm/llvm-project/blob/b7611370491873722e08e4ce9374312d0c936af1/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp#L223, m_parse_time is used to only track the time spent on parsing a DIE in .debug_info, which also doesn't include the time on constructing necessary data structures. This change is trying to do the same by narrowing the time to just on parsing with llvm.  

https://github.com/llvm/llvm-project/pull/86568


More information about the lldb-commits mailing list