[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC (PR #85892)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> I tested the two patches separately.
> 
> With the first one ([Make LineEntry::file private](https://github.com/llvm/llvm-project/pull/85892/commits/0914ecdf582831ec4da776e26ae5ebd2cf9f984f)) my problematic test case still passes.
> 
> When I apply the second one ([Swap FileSpec for SupportFile](https://github.com/llvm/llvm-project/pull/85892/commits/a9a62f28128d9ed667bc311140a994f9e39af7c6)) on top, the test fails as observed with the original change.

@slackito Thanks, that's what I expected, but it still helps narrow things down. Could you do me another favor and try swapping out line 292 in LineTable.cpp for:

```
  line_entry.SetFile(
       std::make_shared<SupportFile>(m_comp_unit->GetSupportFiles().GetFileSpecAtIndex(entry.file_idx)));
```

I'm wondering if we somehow end up comparing it against the file set in `SymbolContext::GetParentOfInlinedScope`:

```
        next_frame_sc.line_entry.SetFile(
             std::make_shared<SupportFile>(curr_inlined_block_inlined_info->GetCallSite().GetFile()));
```

https://github.com/llvm/llvm-project/pull/85892