[Lldb-commits] [lldb] [lldb][nfc] Factor out repeated code in DWIM Print (PR #85669)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 18 10:37:36 PDT 2024


================
@@ -130,7 +130,20 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
     }
   };
 
-  // First, try `expr` as the name of a frame variable.
----------------
kastiglione wrote:

1. I'd prefer to leave the "first", "second", "third" comments. I want to be explicit that there's an order of attempts.
2. You'll need to rebase, I made a change last week that introduce some comments and code that you may need to incorporate.

https://github.com/llvm/llvm-project/pull/85669


More information about the lldb-commits mailing list