[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

Daniel Thornburgh via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 7 13:48:58 PST 2024


mysterymath wrote:

> @mysterymath do you run the API test suites with that custom python, i.e. `ninja check-lldb-api`? If so, would you be able to add bundle `pexpect` for your tests even if it's not in what you ship?

We do run the tests with the Python we ship, since we don't have direct control of the version that is present on our builders, and Python doesn't have ABI compatibility sufficient for LLDB's purposes across major versions. We've generally tried to keep our builds hermetic and not build anything against host libraries unless absolutely necessary.

We could possibly add `pexpect` to our shipped Python, but I haven't scoped what that would entail yet; there may be some bureaucratic hoops to jump through. I wouldn't expect much sympathy on that front of course, but it does seem like adding deps to the Python used by LLDB's test suite does make it more difficult to package a hermetic distribution of LLVM+LLDB.

https://github.com/llvm/llvm-project/pull/84270


More information about the lldb-commits mailing list