[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 7 13:10:37 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r a41226b05510a6f40d99fc622d78853460dc5599...a72d9d259b441c338399340d630ed7a64c1e228a lldb/packages/Python/lldbsuite/test/lldbplatformutil.py lldb/test/API/lang/c/tls_globals/TestTlsGlobals.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- packages/Python/lldbsuite/test/lldbplatformutil.py	2024-03-07 21:07:47.000000 +0000
+++ packages/Python/lldbsuite/test/lldbplatformutil.py	2024-03-07 21:10:29.730620 +0000
@@ -346,11 +346,13 @@
     darwin_platforms = lldbplatform.translate(lldbplatform.darwin_all)
     if getPlatform() not in darwin_platforms:
         return False
 
     try:
-        raw_version_details = subprocess.check_output(("xcrun", "ld", "-version_details"))
+        raw_version_details = subprocess.check_output(
+            ("xcrun", "ld", "-version_details")
+        )
         version_details = json.loads(raw_version_details)
         version = version_details.get("version", "0")
         version_tuple = tuple(int(x) for x in version.split("."))
         if (1000,) <= version_tuple <= (1109,):
             return True

``````````

</details>


https://github.com/llvm/llvm-project/pull/83941


More information about the lldb-commits mailing list