[Lldb-commits] [lldb] [lldb] Address mask sbprocess apis and new mask invalid const (PR #83663)

[David Spickett via lldb-commits]

DavidSpickett wrote:

We could have ABI plugins limit the mask to the known maximum address size, or set all the upper bits to 1. Though I think `0...0<lower 32 of mask>` is less confusing. But it's only fixing what you might call a visual issue, the mask will have upper 32 bits preserved, but at runtime no address will have anything there to preserve, so the result is still correct. We've been storing 32 bit addresses in a 64 bit addr_t for the lifetime of lldb, so if we had problems in this area we'd know already.

I'm inclined to keep it as is (it's simpler) and if people find the current behaviour confusing we can always make some of the plugins fix up the mask just so it looks correct.

(and also, what is correct, top 32 bits of 1s because you can't store them in a 32 bit address, or 0s because there are no bits to preserve anyway :shrug: )

https://github.com/llvm/llvm-project/pull/83663