[Lldb-commits] [lldb] [lldb][test][FreeBSD] Narrow vectorcall xfail to x86 platforms (PR #84024)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 06:59:52 PST 2024


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/84024

vectorcall only works on x86 https://clang.llvm.org/docs/AttributeReference.html#vectorcall so elsewhere it fails to compile. Which is expected on AArch64 for example so is treated as a pass.

>From d86d189b30ff9655c597dcd58490753f8a84e7a8 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Tue, 5 Mar 2024 14:58:17 +0000
Subject: [PATCH] [lldb][test][FreeBSD] Narrow vectorcall xfail to x86
 platforms

vectorcall only works on x86 https://clang.llvm.org/docs/AttributeReference.html#vectorcall
so elsewhere it fails to compile. Which is expected on AArch64 for
example so is treated as a pass.
---
 .../API/lang/c/calling-conventions/TestCCallingConventions.py  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py b/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py
index 9483dfcd040186..0304482e899b82 100644
--- a/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py
+++ b/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py
@@ -62,7 +62,10 @@ def test_stdcall(self):
             return
         self.expect_expr("func(1, 2, 3, 4)", result_type="int", result_value="10")
 
+    # Fails on x86, passes elsewhere because clang doesn't support vectorcall on
+    # any other architectures.
     @expectedFailureAll(
+        triple=re.compile("^(x86|i386)"),
         oslist=["freebsd"], bugnumber="github.com/llvm/llvm-project/issues/56084"
     )
     def test_vectorcall(self):



More information about the lldb-commits mailing list