[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 4 17:43:30 PST 2024


adrian-prantl wrote:

Folks I'm talking this all back. Changing the return type from a uint32_t to a uint64_t is an all-or-nothing affair, because the UINT32_MAX sentinel value is permeating a bunch of other APIs that I have not intention of changing right now. For example, `GetIndexOfChildWithName()`.
I'd like to propose to just unify to `int32_t` here, which is no regression (as evidenced by the SBAPI) and then as I start threading through error handling, we can separately talk about replacing the sentinel values with something else. Then switching to 64 bits is again relatively simple.

https://github.com/llvm/llvm-project/pull/83501


More information about the lldb-commits mailing list