[Lldb-commits] [lldb] ec8df55 - [lldb][test][Windows] Don't check for pexpect with LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 1 01:47:42 PST 2024


Author: David Spickett
Date: 2024-03-01T09:47:17Z
New Revision: ec8df555702d85511290742388d28016b69468de

URL: https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de
DIFF: https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de.diff

LOG: [lldb][test][Windows] Don't check for pexpect with LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

See https://github.com/llvm/llvm-project/issues/22648 for why we don't use it on
Windows. Any pexpect tests are skipped there.

Added: 
    

Modified: 
    lldb/test/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt
index 2a9877c721e3b4..950643a5b8cc8e 100644
--- a/lldb/test/CMakeLists.txt
+++ b/lldb/test/CMakeLists.txt
@@ -11,10 +11,14 @@ endif()
 
 if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
   message(STATUS "Enforcing strict test requirements for LLDB")
-  set(useful_python_modules
-    psutil  # Lit uses psutil to do per-test timeouts.
-    pexpect # We no longer vendor pexpect.
-  )
+  # Lit uses psutil to do per-test timeouts.
+  set(useful_python_modules psutil)
+
+  if(NOT WIN32)
+    # We no longer vendor pexpect and it is not used on Windows.
+    list(APPEND pexpect)
+  endif()
+
   foreach(module ${useful_python_modules})
     lldb_find_python_module(${module})
     if (NOT PY_${module}_FOUND)


        


More information about the lldb-commits mailing list