[Lldb-commits] [lldb] ec95379 - [lldb][test] Clear pexpect found var before checking again
David Spickett via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 29 06:22:31 PST 2024
Author: David Spickett
Date: 2024-02-29T14:22:23Z
New Revision: ec95379df363253ffcbbda21297417e703d5ccca
URL: https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca
DIFF: https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca.diff
LOG: [lldb][test] Clear pexpect found var before checking again
If you run cmake without pexpect installed it errors as expected.
However, if you just `pip install pexpect` and cmake again it still
doesn't find it because it cached the result of the search.
Unset the result before looking for pexpect. So that this works
as expected:
cmake ...
pip3 install pexpect
cmake ...
Added:
Modified:
lldb/test/CMakeLists.txt
Removed:
################################################################################
diff --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt
index d8cbb24b6c9b81..7c31fd487f6ff8 100644
--- a/lldb/test/CMakeLists.txt
+++ b/lldb/test/CMakeLists.txt
@@ -30,6 +30,7 @@ endif()
# LLDB tree. However, we delay the deletion of it from the tree in case
# users/buildbots don't have the package yet and need some time to install it.
if (NOT LLDB_TEST_USE_VENDOR_PACKAGES)
+ unset(PY_pexpect_FOUND CACHE)
lldb_find_python_module(pexpect)
if (NOT PY_pexpect_FOUND)
message(FATAL_ERROR
More information about the lldb-commits
mailing list