[Lldb-commits] [lldb] [lldb] Add SBProcess methods for get/set/use address masks (PR #83095)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 29 02:04:38 PST 2024


================
@@ -33,18 +33,26 @@ void AddressableBits::SetHighmemAddressableBits(
   m_high_memory_addr_bits = highmem_addressing_bits;
 }
 
+addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
+  assert(addressable_bits <= sizeof(addr_t) * 8);
----------------
DavidSpickett wrote:

If we're in release mode, this assert isn't here. Is it possible for the user to set addresable_bits to > 64 via `settings set`?

If they do it's a bit of a garbage in garbage out situation, but wondering if we could add a check at that level too, or already have.

https://github.com/llvm/llvm-project/pull/83095


More information about the lldb-commits mailing list