[Lldb-commits] [lldb] [lldb][test] Exclude third_party packages by default (PR #83191)

[David Spickett via lldb-commits]

DavidSpickett wrote:

>  This introduces a LLDB_TEST_USE_VENDOR_PACKAGES cmake param that can be enabled, and the tests will continue loading that tree.

I get the intent but doing it this way is actually going to be more of an issue. As changes to our bot config have to go through zorg, a master restart, then they finally hit the builders, this takes up to a week sometimes. With this new option defaulting to OFF that means potentially a week of broken builds.

I would suggest making this option default `ON`, and builders can turn it `OFF` once they've installed the right packages. Then finally remove the option altogether. It'll take a longer time but we won't have a period of broken builds during it.

https://github.com/llvm/llvm-project/pull/83191