[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 26 14:23:31 PST 2024
https://github.com/JDevlieghere requested changes to this pull request.
I think this is going in the right direction but I think the interaction between the ProgressManager and the Debugger needs to change:
At a high level I'm expecting:
1. Progress object is created
2. Progress is added to the ProgressManager
3. Debugger::ReportProgress is called with (`eBroadcastBitProgress | eBroadcastBitProgressCategory`)
4. Incremental updates call directly into Debugger::ReportProgress without going through the manager, with just `Debugger::ReportProgress`.
5. When progress is complete, we go through the progress manager again and report the final progress to both broadcast bits: `eBroadcastBitProgress | eBroadcastBitProgressCategory`
https://github.com/llvm/llvm-project/pull/83069
More information about the lldb-commits
mailing list