[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Sun Feb 25 19:48:37 PST 2024


================
@@ -1568,15 +1569,16 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec, bool set_platform,
 
       if (m_arch.GetSpec().IsCompatibleMatch(other)) {
         compatible_local_arch = true;
-        bool arch_changed, vendor_changed, os_changed, os_ver_changed,
-            env_changed;
 
-        m_arch.GetSpec().PiecewiseTripleCompare(other, arch_changed,
-                                                vendor_changed, os_changed,
-                                                os_ver_changed, env_changed);
-
-        if (!arch_changed && !vendor_changed && !os_changed && !env_changed)
+        if (m_arch.GetSpec().GetTriple() == other.GetTriple())
           replace_local_arch = false;
+        // Workaround for for pre-2024 debugserver, which always
+        // returns arm64e on arm64e-capable hardware regardless of
+        // what the process is. This can be deleted at some point in
+        // the future.
----------------
jasonmolenda wrote:

Another way of saying this -- we DO have a version packet, but it is kinda not doing what we need, so maybe we should redefine what it returns.  We added it but never actually used it in lldb, we can change what it returns without breaking anything.

https://github.com/llvm/llvm-project/pull/82938


More information about the lldb-commits mailing list