[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)

Jessica Clarke via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 17:08:47 PST 2024


jrtc27 wrote:

Also this is the kind of commit that should really be done by a core trusted member of the community. It's way too easy to hide something nefarious (not that I'm accusing you of that, just that we always need to be vigilant) in an 8k+ diff, and it's not much fun to review that code. Also it's best when people provide the scripts used to do these kinds of mass changes; that (a) lets people verify what you did by auditing the script and running it themselves (b) lets downstreams easily perform the same change on their forks.

The fact that this is a +8347 -8382 diff also confuses me; I would expect the number of lines to remain constant, but maybe you're including trailing blank lines as trailing whitespace?..

https://github.com/llvm/llvm-project/pull/82838


More information about the lldb-commits mailing list