[Lldb-commits] [lldb] [lldb] Correctly annotate threads at a bp site as hitting it (PR #82709)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 14:00:40 PST 2024


jasonmolenda wrote:

> This seems safe to me, and it can't hurt to take care of this corner case here regardless of what the higher levels of lldb does.

This all falls under `Thread::CalculateStopInfo()` - `ThreadGDBRemote::CalculateStopInfo` is calling into ProcessGDBRemote where we do this.  The base class method is pure virtual, so I'm not sure there's a higher level place where this logic could be situated.  I updated the PR with a comment on `Thread::CalculateStopInfo()` specifically detailing this issue, so people writing new subclasses can (hopefully) be aware of it.

https://github.com/llvm/llvm-project/pull/82709


More information about the lldb-commits mailing list