[Lldb-commits] [lldb] [lldb] Correctly annotate threads at a bp site as hitting it (PR #82709)

via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 09:31:54 PST 2024


https://github.com/jimingham approved this pull request.

This seems safe to me, and it can't hurt to take care of this corner case here regardless of what the higher levels of lldb does.

It bugs me a little that we're treating what seems like a general problem down in the GDBRemote process plugin.  But anyway, if we are going to make this a process plugin policy: that the plugins are responsible for producing breakpoint stop reasons both for when the underlying system generates one and when we see "artificial" hits like this we should probably say so somewhere.

With the couple doc comments aside, I'm fine with this.

https://github.com/llvm/llvm-project/pull/82709


More information about the lldb-commits mailing list