[Lldb-commits] [lldb] [lldb] [debugserver] fix qLaunchSuccess error, add QErrorStringInPacketSupported (PR #82593)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 22 10:43:49 PST 2024


================
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
         // The order of these checks is important.  
         if (process_does_not_exist (pid_attaching_to)) {
           DNBLogError("Tried to attach to pid that doesn't exist");
-          std::string return_message = "E96;";
-          return_message += cstring_to_asciihex_string("no such process.");
+          std::string return_message = "E96";
+          if (m_enable_error_strings) {
+            return_message += ";";
+            return_message += cstring_to_asciihex_string("no such process.");
----------------
clayborg wrote:

we probably want all error details to be ended with a '.' or all of them to not have a '.' at the end. See other error message below that don't have a '.' character

https://github.com/llvm/llvm-project/pull/82593


More information about the lldb-commits mailing list