[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

Jordan Rupprecht via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 21 23:09:25 PST 2024


================
@@ -9,43 +9,27 @@
 #include "gtest/gtest.h"
 
 #include "Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h"
-#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h"
-#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h"
 #include "Plugins/ScriptInterpreter/Python/lldb-python.h"
 
-#include "lldb/Host/FileSystem.h"
-#include "lldb/Host/HostInfo.h"
-
 #include "PythonTestSuite.h"
 #include <optional>
 
-using namespace lldb_private;
-class TestScriptInterpreterPython : public ScriptInterpreterPythonImpl {
-public:
-  using ScriptInterpreterPythonImpl::Initialize;
-};
-
 void PythonTestSuite::SetUp() {
-  FileSystem::Initialize();
----------------
rupprecht wrote:

FWIW, I think it's appropriate that `FileSystem::Initialize()` is removed here, because `PythonTestSuite` itself does not seem to interact w/ `FileSystem`. But `PythonDataObjectsTests.cpp` does, so it should be the one to take care of `FileSystem::Initialize()`.

https://github.com/llvm/llvm-project/pull/82096


More information about the lldb-commits mailing list