[Lldb-commits] [lldb] Make ValueObjectPrinter's handling of its ValueObject pointers more principled (NFC) (PR #81314)

via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 9 15:24:34 PST 2024


jimingham wrote:

The other thing I'm trying to eliminate is problem arising from the way the old code started with `m_valobj` primed to `nullptr` and then getting set by calling GetMostSpecializedValue, but then not always accessing it through that API, but often accessing `m_valobj` directly.  So you could by accident have forgotten to call GetMostSpecializedValue before you accessed the `m_valobj`.  Again, I read closely through the code to see if this could happen IRL and I don't see how it could.  By making that impossible, if that was the problem, this should define it away.


https://github.com/llvm/llvm-project/pull/81314


More information about the lldb-commits mailing list