[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

@clayborg The idea behind the feature is to get symbols for things that are relevant to the user. Right now, that's only hooked up for images that appear in the stack trace, but there are certainly other places this would be useful. So yeah, I absolutely expect this to apply to other things in the future as well. 

We currently check the setting right before downloading, so in a generic place that would be shared by all the other places that could trigger a download. Therefore I think the "mode" should be generic. If we have different triggers we could have separate settings to turn those things off (e.g. only download symbols for images in the stack trace, not for address lookups). So down the line it could look something like this:

```
(lldb) settings set symbols.auto-download background
(lldb) settings set symbols.auto-download-stack-symbols true
(lldb) settings set symbols.auto-download-address-lookup false
```

Let me know if you think it's critical to add `symbols.auto-download-stack-symbols` now in addition to `symbols.auto-download` (which I like better than `symbols.download`, thanks for the suggestion!) . 

https://github.com/llvm/llvm-project/pull/80890