[Lldb-commits] [lldb] Add more ways to find the .dwp file. (PR #81067)

[Greg Clayton via lldb-commits]

clayborg wrote:

> Will this now work with .dwp files not having UUID?

No. If binairies have UUIDs (GNU build IDs), they need to match right now. That is larger fix that involves adding a "enum UUIDFlavor" to the UUIDs so we can ensure we aren't comparing two different things.

What Alexander is talking about is if we have a GNU build ID in `<exe>`, the `<exe>.debug` file will have the same UUID, but llvm-dwp currently doesn't copy the GNU build ID over into the `.dwp` file. This causes LLDB to not allow the .dwp file to be loaded. The problem is if the .dwp file doesn't have a UUID, it will make one up by calculating a CRC of the file itself, and then we will compare a GNU build ID from `<exe>` to the CRC calculated by the `.dwp` file and they won't match.

@dwblaikie do you know how accurate the DWO ID is? Can we avoid relying on matching up the UUID on the .dwp file and solely rely on allowing it to be loaded and rely on the DWO IDs matching between the skeleton unit and the .dwo unit? If so, there is an easy fix I can make to this patch to solve that problem.


https://github.com/llvm/llvm-project/pull/81067