[Lldb-commits] [lldb] [lldb] Add comment to ParseInternal in FormatEntity (NFC) (PR #81018)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 7 10:37:44 PST 2024


================
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format, Entry &parent_entry,
                   return error;
                 }
               } else if (FormatManager::GetFormatFromCString(
-                             entry.printf_format.c_str(), true, entry.fmt)) {
+                             entry.printf_format.c_str(), true,
+                             entry.fmt)) { // Try GetFormatFromCString again,
----------------
kastiglione wrote:

doing partial from the outset would incorrectly match `%V` as `void` – the correct behavior is to print the lldb **V**alue. It's definitely not an ideal setup.

https://github.com/llvm/llvm-project/pull/81018


More information about the lldb-commits mailing list