[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 7 10:19:38 PST 2024


https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/81018

>From f9d4abddb0f93d27ed14278566796babad9f7f4e Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Wed, 7 Feb 2024 10:17:51 -0800
Subject: [PATCH] [lldb] Add comment to ParseInternal in FormatEntity

---
 lldb/source/Core/FormatEntity.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lldb/source/Core/FormatEntity.cpp b/lldb/source/Core/FormatEntity.cpp
index 3c665c2eb2133..b206b6e9983b8 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format, Entry &parent_entry,
                   return error;
                 }
               } else if (FormatManager::GetFormatFromCString(
-                             entry.printf_format.c_str(), true, entry.fmt)) {
+                             entry.printf_format.c_str(), true,
+                             entry.fmt)) { // Try GetFormatFromCString again,
+                                           // with partial_match_ok = true.
                 clear_printf = true;
               } else if (entry.printf_format == "tid") {
                 verify_is_thread_id = true;



More information about the lldb-commits mailing list