[Lldb-commits] [lldb] Fix a crasher when using the public API. (PR #80508)

via lldb-commits lldb-commits at lists.llvm.org
Sat Feb 3 00:35:04 PST 2024


================
@@ -1089,9 +1089,9 @@ void SBDebugger::SetSelectedTarget(SBTarget &sb_target) {
   Log *log = GetLog(LLDBLog::API);
 
   TargetSP target_sp(sb_target.GetSP());
-  if (m_opaque_sp) {
+  if (m_opaque_sp && target_sp)
     m_opaque_sp->GetTargetList().SetSelectedTarget(target_sp);
----------------
kusmour wrote:

Had a discussion with Greg earlier:

> A default constructed SBTarget should have an invalid shared pointer, so this shouldn't ever try to be added to the list...

So I think the change here is good

https://github.com/llvm/llvm-project/pull/80508


More information about the lldb-commits mailing list