[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 2 09:15:04 PST 2024


jimingham wrote:

I think that makes the most sense.

Jim

> On Feb 2, 2024, at 1:45 AM, Michael Buch ***@***.***> wrote:
> 
> 
> The patch looks fine to me, but I'm a bit bugged by the fact that it is in Target. In my mind, this is part of the C LanguageRuntime, except we don't yet have a C Language Runtime... But in any case, somewhere more specific than Target.
> 
> Seems reasonable to me. Should I create a CLanguageRuntime plugin and move the AssertRecognizedStackFrame there then? I'll open a separate PR for this then
> 
>> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/80368#issuecomment-1923441090>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW2EKJES7NXFOC27SJDYRSYTPAVCNFSM6AAAAABCV3DNHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRTGQ2DCMBZGA>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/80368


More information about the lldb-commits mailing list