[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

> I didn't have time to review before merge, just looking at this now.
> 
> > see what the Windows CI thinks.
> 
> I assume you mean the buildbots (lldb isn't built in the pre-commit CI), but I think given: https://github.com/llvm/llvm-zorg/blob/590f0a62919ad313758362d18a31e7d40255e6e6/buildbot/osuosl/master/config/builders.py#L1342 The tests wouldn't run there anyway due to `--skip-category=watchpoint`.

Ah, thanks.  I saw the buildbot fail and assumed it was from the TestUnalignedLargeWatchpoint test I added.  But it was more likely by the fact (Jonas later pointed out) that the compiler on Windows doesn't have `__builtin_clzll` which I was using (I switched to the llvm equiv in the final version).


https://github.com/llvm/llvm-project/pull/79962