[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 1 10:35:49 PST 2024


jimingham wrote:

I agree with Dave that verbs would be more naturally follow the intent of the return.  Since the return is telling the caller: either "You can reuse the children you have cached" or "you must refetch the children".  So `eReuse`, `eRefetch` would produce code like:

  if (something.Update() ==  ChildCacheState::eRefetch) {
      // Blow away the cached children and refetch.
 }

That seems pretty natural.
  

https://github.com/llvm/llvm-project/pull/80167


More information about the lldb-commits mailing list