[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

[David Spickett via lldb-commits]

================
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h ----------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLDB_BREAKPOINT_WATCHPOINTALGORITHMS_H
+#define LLDB_BREAKPOINT_WATCHPOINTALGORITHMS_H
+
+#include "lldb/Breakpoint/WatchpointResource.h"
+#include "lldb/Utility/ArchSpec.h"
+#include "lldb/lldb-public.h"
+
+#include <vector>
+
+namespace lldb_private {
+
+class WatchpointAlgorithms {
+
+public:
+  /// Convert a user's watchpoint request into an array of memory
----------------
DavidSpickett wrote:

Does this mean
one register = one memory region
Or
one register = all the memory regions (at once)

I think the former but the phrasing implies the latter.

How about:
"an array of memory regions, each of which can be watched by one"

https://github.com/llvm/llvm-project/pull/79962