[Lldb-commits] [lldb] dad50fe - Add extra printing to TestWatchpointCount.py to debug CI fail

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 31 10:03:39 PST 2024


Author: Jason Molenda
Date: 2024-01-31T10:02:22-08:00
New Revision: dad50fefa24e717927a4d3315ae70fe507d624e0

URL: https://github.com/llvm/llvm-project/commit/dad50fefa24e717927a4d3315ae70fe507d624e0
DIFF: https://github.com/llvm/llvm-project/commit/dad50fefa24e717927a4d3315ae70fe507d624e0.diff

LOG: Add extra printing to TestWatchpointCount.py to debug CI fail

The way the locals are laid out on the stack on x86-64 Debian is
resulting in a test failure with the new large watchpoint support.
Collecting more logging before I revert/debug it.

Added: 
    

Modified: 
    lldb/test/API/commands/watchpoints/watchpoint_count/TestWatchpointCount.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/watchpoints/watchpoint_count/TestWatchpointCount.py b/lldb/test/API/commands/watchpoints/watchpoint_count/TestWatchpointCount.py
index 8d7f37aecb25f..be0618bfb4b11 100644
--- a/lldb/test/API/commands/watchpoints/watchpoint_count/TestWatchpointCount.py
+++ b/lldb/test/API/commands/watchpoints/watchpoint_count/TestWatchpointCount.py
@@ -29,6 +29,12 @@ def test_watchpoint_count(self):
         second_watch = second_var.Watch(True, False, True, error)
         if not error.Success():
             self.fail("Failed to make watchpoint for x2: %s" % (error.GetCString()))
+        # LWP_TODO: Adding temporary prints to debug a test
+        # failure on the x86-64 Debian bot.
+        self.runCmd("p &x1")
+        self.runCmd("p &x2")
+        self.runCmd("watchpoint list")
+
         process.Continue()
 
         stop_reason = thread.GetStopReason()
@@ -39,6 +45,11 @@ def test_watchpoint_count(self):
         self.assertEqual(stop_reason_descr, "watchpoint 1")
 
         process.Continue()
+        # LWP_TODO: Adding temporary prints to debug a test
+        # failure on the x86-64 Debian bot.
+        self.runCmd("frame select 0")
+        self.runCmd("disassemble")
+
         stop_reason = thread.GetStopReason()
         self.assertStopReason(
             stop_reason, lldb.eStopReasonWatchpoint, "watchpoint for x2 not hit"


        


More information about the lldb-commits mailing list