[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

[Jonas Devlieghere via lldb-commits]

================
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp ------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "lldb/Breakpoint/WatchpointAlgorithms.h"
+#include "lldb/Breakpoint/WatchpointResource.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Utility/ArchSpec.h"
+
+#include <utility>
+#include <vector>
+
+using namespace lldb;
+using namespace lldb_private;
+
+std::vector<WatchpointResourceSP>
+WatchpointAlgorithms::AtomizeWatchpointRequest(
+    addr_t addr, size_t size, bool read, bool write,
+    WatchpointHardwareFeature supported_features, ArchSpec &arch) {
+
+  std::vector<std::pair<addr_t, size_t>> entries;
+
+  if (supported_features &
+      WatchpointHardwareFeature::eWatchpointHardwareArmMASK) {
+    entries =
+        PowerOf2Watchpoints(addr, size,
+                            /* min_byte_size */ 1,
+                            /* max_byte_size */ INT32_MAX,
+                            /* address_byte_size */ arch.GetAddressByteSize());
----------------
JDevlieghere wrote:

Nit: `/*min_byte_size=*/` is the prevailing style in LLDB (no spaces and `=`).

https://github.com/llvm/llvm-project/pull/79962