[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #78977)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff cabe8be6bb2120828a741217365be975c59ac7b6 639295de7bdd4a2e710b62337a511ded92eb702a -- lldb/include/lldb/Expression/DWARFExpression.h lldb/source/Expression/DWARFExpression.cpp lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h lldb/unittests/Expression/DWARFExpressionTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Expression/DWARFExpression.cpp b/lldb/source/Expression/DWARFExpression.cpp
index 7298ccbf99..f2c39fe991 100644
--- a/lldb/source/Expression/DWARFExpression.cpp
+++ b/lldb/source/Expression/DWARFExpression.cpp
@@ -94,7 +94,6 @@ void DWARFExpression::SetRegisterKind(RegisterKind reg_kind) {
   m_reg_kind = reg_kind;
 }
 
-
 // static
 bool DWARFExpression::ReadRegisterValueAsScalar(RegisterContext *reg_ctx,
                                                 lldb::RegisterKind reg_kind,
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
index 72a831a8ab..b2df332615 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -330,7 +330,7 @@ llvm::StringRef SymbolFileDWARF::GetPluginDescriptionStatic() {
 SymbolFile *SymbolFileDWARF::CreateInstance(ObjectFileSP objfile_sp) {
   if (llvm::isa<lldb_private::wasm::ObjectFileWasm>(*objfile_sp))
     return new wasm::SymbolFileWasm(std::move(objfile_sp),
-                              /*dwo_section_list*/ nullptr);
+                                    /*dwo_section_list*/ nullptr);
   return new SymbolFileDWARF(std::move(objfile_sp),
                              /*dwo_section_list*/ nullptr);
 }
@@ -4538,7 +4538,6 @@ bool SymbolFileWasm::ParseVendorDWARFOpcode(
                                                  error_ptr, tmp)) {
     stack.push_back(tmp);
     return true;
-  }
-  else
+  } else
     return false;
 }
diff --git a/lldb/unittests/Expression/DWARFExpressionTest.cpp b/lldb/unittests/Expression/DWARFExpressionTest.cpp
index 82bcf9695a..065492bf41 100644
--- a/lldb/unittests/Expression/DWARFExpressionTest.cpp
+++ b/lldb/unittests/Expression/DWARFExpressionTest.cpp
@@ -785,7 +785,7 @@ static auto testExpressionVendorExtensions(lldb::ModuleSP module_sp,
   DWARFExpression dwarf_expr(extractor);
   ASSERT_TRUE(dwarf_expr.ContainsThreadLocalStorage(&dwarf_unit));
 }
-} // namespace;
+} // namespace
 
 TEST(DWARFExpression, Extensions) {
   const char *yamldata = R"(

``````````

</details>


https://github.com/llvm/llvm-project/pull/78977