[Lldb-commits] [lldb] [lldb][NFCI] Remove unused method BreakpointIDList::AddBreakpointID(const char *) (PR #79189)
via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 23 10:37:23 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
<details>
<summary>Changes</summary>
This overload is completely unused.
---
Full diff: https://github.com/llvm/llvm-project/pull/79189.diff
2 Files Affected:
- (modified) lldb/include/lldb/Breakpoint/BreakpointIDList.h (-2)
- (modified) lldb/source/Breakpoint/BreakpointIDList.cpp (-9)
``````````diff
diff --git a/lldb/include/lldb/Breakpoint/BreakpointIDList.h b/lldb/include/lldb/Breakpoint/BreakpointIDList.h
index 3cda1860dc16721..6c57d9bc507952f 100644
--- a/lldb/include/lldb/Breakpoint/BreakpointIDList.h
+++ b/lldb/include/lldb/Breakpoint/BreakpointIDList.h
@@ -42,8 +42,6 @@ class BreakpointIDList {
bool AddBreakpointID(BreakpointID bp_id);
- bool AddBreakpointID(const char *bp_id);
-
// TODO: This should take a const BreakpointID.
bool FindBreakpointID(BreakpointID &bp_id, size_t *position) const;
diff --git a/lldb/source/Breakpoint/BreakpointIDList.cpp b/lldb/source/Breakpoint/BreakpointIDList.cpp
index 51185c30dabad8c..5ab2c9a8dc3865b 100644
--- a/lldb/source/Breakpoint/BreakpointIDList.cpp
+++ b/lldb/source/Breakpoint/BreakpointIDList.cpp
@@ -48,15 +48,6 @@ bool BreakpointIDList::AddBreakpointID(BreakpointID bp_id) {
// return true.
}
-bool BreakpointIDList::AddBreakpointID(const char *bp_id_str) {
- auto bp_id = BreakpointID::ParseCanonicalReference(bp_id_str);
- if (!bp_id)
- return false;
-
- m_breakpoint_ids.push_back(*bp_id);
- return true;
-}
-
bool BreakpointIDList::FindBreakpointID(BreakpointID &bp_id,
size_t *position) const {
for (size_t i = 0; i < m_breakpoint_ids.size(); ++i) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/79189
More information about the lldb-commits
mailing list