[Lldb-commits] [lldb] bd3838f - Skip TestThreadLocal.py on darwin temporarily for linker issue

[Jason Molenda via lldb-commits]

Author: Jason Molenda
Date: 2024-01-19T17:03:19-08:00
New Revision: bd3838ff6b4310fb8ff68649ef87e5e962bab1fd

URL: https://github.com/llvm/llvm-project/commit/bd3838ff6b4310fb8ff68649ef87e5e962bab1fd
DIFF: https://github.com/llvm/llvm-project/commit/bd3838ff6b4310fb8ff68649ef87e5e962bab1fd.diff

LOG: Skip TestThreadLocal.py on darwin temporarily for linker issue

The new static linker in Xcode 15 does not emit the necessary
symbols for file static thread local storage, causing this test
to fail when used.  The old static linker is still available
as ld-classic in Xcode 15, but it has to be invoked specially, and
the new static linker will be fixed at some point.  I may try to
add linker name and versioning information in
lldb/packages/Python/lldbsuite/test/decorators.py like we do with
the compiler / compiler_version, so it can be xfailed for known
problematic static linker name / versions, but until I get that
sorted I'm skipping this test to unblock the CI bots.

Added: 
    

Modified: 
    lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py b/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
index 636e4819ea29892..9b128ba6097acb8 100644
--- a/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
+++ b/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
@@ -9,6 +9,7 @@
 
 class PlatformProcessCrashInfoTestCase(TestBase):
     @expectedFailureAll(oslist=["windows", "linux", "freebsd", "netbsd"])
+    @skipIfDarwin  # rdar://120795095
     def test_thread_local(self):
         # Set a breakpoint on the first instruction of the main function,
         # before the TLS initialization has run.